Bug in Hitchhiker Theme: generateCTAFieldTypeLink throws an error if linkType is null

Jason_Ronkin · March 8, 2022, 7:39pm

Hi, I’m not sure if this is the right place to post, but I’ve encountered a bug in the Hitchhikers Answers theme. The isLinkTypeInTranslations function used by the generateCTAFieldTypeLink formatter in generate-cta-field-type-link.js throws an error if linkType is null or undefined, which can happen if the Label subfield of a CTA field is populated but the Link subfield is not.

GitHub link:

github.com

yext/answers-hitchhiker-theme/blob/master/static/js/formatters/generate-cta-field-type-link.js#L101


      
          
          
/**
           * Whether or not the given CTA linkType is included in a translations object's values.
           * 
           * @param {string} linkType 
           * @param {Array<string>} translations
           * @returns {boolean}
           */
          function isLinkTypeInTranslations(linkType, translations) {
            return !!translations.find(translation => {
              return translation.toLowerCase() === linkType.toLowerCase()
            });
          }

roser · March 8, 2022, 10:03pm

Thanks Jason! We’ll get this fixed in an upcoming release.

Topic		Replies	Views
Expected behavior of CTA Link Type Best Practices - Search Front-End	3	1686	March 4, 2021
Answers - Email and Phone CTAs for Non-English Profiles Bug Reporting	0	1029	February 10, 2021
Customizing CTA Behavior Search	1	803	February 18, 2021
Creating a new vertical end to end Best Practices - Search Configuration	6	1130	August 11, 2021
Error in Answers > Module 13 > Final Assessment	1	757	November 11, 2020

Bug in Hitchhiker Theme: generateCTAFieldTypeLink throws an error if linkType is null

Related topics